Adapt to coq#19611 #1402
Merged
Adapt to coq#19611 #1402
+64
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess it's Coq? (commit title too) |
|
Yes, thanks. |
+1 |
zstone1
approved these changes
Nov 19, 2024
|
As discussed here, I changed the context in which a few lemmas are declared, along with some typing annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#1300 was merged between the last CI of coq/coq#19611 and it being merged. It so happens that the latter PR breaks the former, so this fixes it.
N.B. I am confused that there is a
TopologicalLmodulestructure butnbhs0N_subproofis defined with atopologicalTypewith aGRing.Lmoduleclass. @mkerjean pointed me to #1300 (comment). Would it make sense to redefine the section in order to useTopologicalLmodule.type.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers